Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if byte array is list before converting to utf-8 #51

Closed
wants to merge 1 commit into from
Closed

check if byte array is list before converting to utf-8 #51

wants to merge 1 commit into from

Conversation

walterbender
Copy link
Member

Since F19, the keyboard section of the cpsection fails when converting a byte array to utf-8. This is because the byte array isinstance list instead of isinstance string. Not sure of the root cause of this change, but this patch checks the type and does a proper conversion in either case. (See http://bugs.sugarlabs.org/ticket/4539)

@dnarvaez
Copy link
Contributor

dnarvaez commented Jul 5, 2013

We need to understand what is going on here. The original _item_str looks weird to start with.

@dnarvaez
Copy link
Contributor

dnarvaez commented Jul 5, 2013

@dnarvaez
Copy link
Contributor

dnarvaez commented Jul 5, 2013

I suppose we should depend on 5.4 and use those accessors.

@dnarvaez
Copy link
Contributor

dnarvaez commented Jul 5, 2013

Though Fedora 19 doesn't have 5.4. Maybe see what Peter thinks about getting 5.4 in F19? The other distros doesn't even have 5.3 which I think we need for other reasons, so it's not going to make things worse there.

If we can get 5.4 in Fedora I'd just use the accessors, otherwise I guess we need to keep a fallback doing conversions.

@dnarvaez
Copy link
Contributor

dnarvaez commented Jul 5, 2013

I can build 5.4 in sugar-build btw, but lets first decide the approach we are taking.

@walterbender
Copy link
Member Author

I think using the xklavier accessors makes sense; we can get rid of the kludgy helper method all together.

@dnarvaez
Copy link
Contributor

dnarvaez commented Jul 5, 2013

Closing then.

@dnarvaez dnarvaez closed this Jul 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants