Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add escape key to close help #518

Merged
merged 1 commit into from May 26, 2015
Merged

Conversation

quozl
Copy link
Contributor

@quozl quozl commented May 24, 2015

For consistency with other modal dialogs such as view source and control panel, add a handler to translate escape key into stop button.

Tested on XO-4 with 14.1.0 and Sugar 0.105.1, using this method:

  • change file on target, restart display manager:
rsync src/jarabe/view/viewhelp.py \
    target:/usr/lib/python2.7/site-packages/jarabe/view/viewhelp.py
ssh target service olpc-dm restart
  • start Implode activity, use Alt-Shift-H to display help window,
  • press Escape, and window does close,
  • check for interesting logs.

For consistency with other modal dialogs such as view source and control
panel, add a handler to translate escape key into stop button.
@godiard godiard merged commit 0a7fd61 into sugarlabs:master May 26, 2015
@godiard
Copy link
Contributor

godiard commented May 26, 2015

Thanks, merged

@quozl quozl deleted the 2015-05-vh-esc branch September 11, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants