Simplify logic to apply jabber server config changes - Fixes #4865 #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There multiples fixes here: * On apply_jabber method, don't compare with the model._get_jabber function, but with the result of executing the function. * jabber set/get method don't throw ReadError exceptions, then do not have sense cathit here, or have a jabber_alert. Remove all the logic. Probably copied from __radio_toggled_cb, but not needed here. * Make apply_jabber private, is a internal implementation.
|
Tested, Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
There multiples fixes here:
function, but with the result of executing the function.
then do not have sense cathit here, or have a jabber_alert.
Remove all the logic. Probably copied from __radio_toggled_cb,
but not needed here.