Don't check window type before change view - Fixes #4795 #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code removed was introduced on commit 9406c42 to avoid change views when the My Settings window was opened, but that didn't worked, and we added the control of modal windows on the shell on 1495676 to solve that case. But this control have the lateral effect of block change the views when a popup is opened. Remove this control solves the problem.
|
Reviewed. Tested on XO-1 with Sugar 0.105.2, does fix #4795. Thanks! |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code removed was introduced on commit 9406c42 to avoid change
views when the My Settings window was opened, but that didn't worked,
and we added the control of modal windows on the shell on 1495676
to solve that case.
But this control have the lateral effect of block change the views
when a popup is opened. Remove this control solves the problem.