Delay reset home cursor at startup if window is not created - Fixes #… #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4873 This patch delay the reset of the Clock cursor set at Sugar startup until the window is created. The bug is probably originated by a race condition and is difficult to reproduce.
|
@quozl, I didn't find a way to reproduce the problem, testing on a XO-1 |
|
Reviewed. |
|
@quozl did you test? |
|
No, and nor do I think it necessary. A full test would require the problem to be easily reproducible, and as you know it isn't. Gonzalo's patch does fix a theoretical race condition. Do you have a doubt that you aren't expressing? |
|
No, I have no doubts. I just thought you were able to test it and reproduce it. I'll test if it has any effect on the normal (non racy) running of the shell and merge accordingly. |
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
…4873
This patch delay the reset of the Clock cursor set at Sugar startup
until the window is created. The bug is probably originated by a
race condition and is difficult to reproduce.