More robust i18n try3 #558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have received a few reports of broken ~/.i18n files Try to make the code more robust, using "with" to open the files, and remove redundancy in the code. Only write the file when set the languages, and flush to try avoid have a broken file. When read the languages, get the values from the enviroment variables set on bin/sugar. If the file ~/.i18n exists, was already read there.
When the user press the cancel button in the control panel section, the ModelWrapper object (in gui.py) try to revert the changes and write the initial values, even if nothing has changed. As the recording of the values is triggered by a timeout, we don't have another way to avoid race contions that verify at the moment of write the file.
…#4878 When the user press the (+) button and a new language row is added, the _add_row method receive locale_code=None. To make the method manage this case properly, we need do two changes: * Do not check in the available locales because None will not get any value. * When add the locale_code to self._country_codes, set the locale based in the default values displayed to the user. A consequence of the method not managing the None case, id that changes will not be saved until the user change the default value displayed to the user.
|
@samdroid-apps, I addressed your comments in the next patch (Before open....) |
|
|
||
| try: | ||
| with open(path, 'w') as fd: | ||
| fd.write(new_lang_line) |
There was a problem hiding this comment.
Lines 105 to 110 do not preserve previous unrelated contents of file. Since the file can contain locale environment variables like currency and date format, this is impolite to other software.
Merged
|
Replaced by #560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Replaces #557