Fix journal palettes when missing contact connection #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the journal palettes are being created, it checks whether or not there are friends to be added to the send-to menu. This check is being done via the file_transfer_available helper. The helper uses the telepathy connection watcher and, under some circunstances that I haven't been able to reproduce, the connections in the watcher cannot be reached via the DBus interface. When this happens, an unhandled DBusException is thrown, breaking the palette. In other words, the journal palettes are not being displayed anymore until the shell session is restarted. This issue was noticed running on Ubuntu 14.04. Created a ticket to track the source of this issue in SL#4887. This patch improves the robustness of this helper, but it logs the error so we don't loose track of this issue. Signed-off-by: Martin Abente Lahaye <tch@sugarlabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When the journal palettes are being created, it checks whether
or not there are friends to be added to the send-to menu. This
check is being done via the file_transfer_available helper.
The helper uses the telepathy connection watcher and, under some
circunstances that I haven't been able to reproduce, the connections
in the watcher cannot be reached via the DBus interface.
When this happens, an unhandled DBusException is thrown, breaking
the palette. In other words, the journal palettes are not being
displayed anymore until the shell session is restarted.
This issue was noticed running on Ubuntu 14.04. Created a ticket to
track the source of this issue in SL#4887.
This patch improves the robustness of this helper, but it logs the error
so we don't loose track of this issue.
Signed-off-by: Martin Abente Lahaye tch@sugarlabs.org