Add setting for frame trigger size, fixes #4835 #571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sugar is run inside a window, the frame trigger is a very target to hit. This can be improved by making the trigger area bigger, however it is only needed in some environments, not those where sugar is fullscreen. Ticket URL <https://bugs.sugarlabs.org/ticket/4835>
|
It is a feature that fixes a bug. The feature will also assist in environments that are not virtualised. Reviewed, like it. |
|
Thanks for the fix, I've cherry-picked it for an OLPC fork. |
|
Conflict resolved on OLPC fork; apply() method will need code added for handling trigger_size sid, in the same way as in f481ecd. |
|
Replaced by #601 where the merge conflicts are resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When sugar is run inside a window, the frame trigger is a very target to hit.
This can be improved by making the trigger area bigger, however it is only
needed in some environments, not those where sugar is fullscreen.
Ticket URL https://bugs.sugarlabs.org/ticket/4835
BTW: Not 100% sure if this is a bug fix or a feature. It's pretty small, but whatever😄