Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear journal search with escape key #578

Conversation

nemesiscodex
Copy link
Contributor

As mentioned in the issue #4892

search entry box is cleared with escape key in

  • neighbourhood view,
  • friends view, and;
  • home view (list and circle),

but not in journal.
when a journal entry is expanded, the escape key returns to the main journal view. (_key_press_event_cb in journalactivity.py)
please also clear the search entry. ;-)

Regards

@samdroid-apps
Copy link
Contributor

Looks good code wise, haven't tested.

Could you change the commit message a little? If you put "fixes #4892" first line, instead of on the 2nd line?

Signed-off-by: Julio Reyes <nemesiscodex@gmail.com>
@nemesiscodex nemesiscodex force-pushed the clear-journal-search-with-escape-key branch from cdc785a to 0c345fb Compare October 9, 2015 06:07
@nemesiscodex
Copy link
Contributor Author

Like that? 😅

@samdroid-apps samdroid-apps merged commit 0c345fb into sugarlabs:master Oct 9, 2015
@samdroid-apps
Copy link
Contributor

Merged! I would usually put the fixes #ABCD at the end, but it doesn't matter too much

@nemesiscodex
Copy link
Contributor Author

I will keep that in mind for the next one 😄 thanks!

@quozl
Copy link
Contributor

quozl commented Oct 9, 2015

added pr to ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants