Check if remove_alert is present in toplevel #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the toplevel is changed to DocumentButton, and there is no remove_alert on DocumentButton. The idea is to check if there is remove_alert on toplevel, to prevent a false function call
|
Does the alert get removed automatically? |
|
Nop, if I don't call remove_alert it's not automatic 2015-10-09 19:14 GMT-02:00, Sam notifications@github.com:
Ignacio Rodríguez |
|
I've made a ticket for this bug: https://bugs.sugarlabs.org/ticket/4898 |
|
I think we should wait until we understand what this bug is before we patch it. Them maybe we can make an even better patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Sometimes the toplevel is changed to DocumentButton,
and there is no remove_alert on DocumentButton.
The idea is to check if there is remove_alert on toplevel,
to prevent a false function call
I made this patch because of this error in logs after duplicate activity (appears -I think- 10 seconds after the duplication process)
Traceback (most recent call last): File "/home/broot/sugar-build/build/out/install/lib/python2.7/site-packages/jarabe/view/viewsource.py", line 470, in __alert_response_cb self.get_toplevel().remove_alert(alert) AttributeError: 'DocumentButton' object has no attribute 'remove_alert'