Add setting for frame trigger size, fixes #4835 #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sugar is run inside a window, the frame trigger is a very small target to hit. This can be improved by making the trigger area bigger, however it is only needed in some environments, not those where sugar is fullscreen. Ticket URL <https://bugs.sugarlabs.org/ticket/4835>
|
Reviewed. |
|
@godiard, thanks, but there is no merge button for me. I've not been inducted as a Sugar Labs maintainer. I'm fine with forking, it's how I can bypass the comparatively slow review and merge process when a deadline is at hand. I'm responsible for merging my fork back once the rest of the universe catches up. I'm expecting @samdroid-apps and @i5o will merge. My "Reviewed" comments on pull requests are my record-keeping; if they are too noisy, sorry. |
|
A admin of the organization in github should add @quozl as committer... I will merge |
i5o
added a commit
that referenced
this pull request
Nov 3, 2015
Add setting for frame trigger size, fixes #4835
| def get_trigger_size(): | ||
| settings = Gio.Settings('org.sugarlabs.frame') | ||
| edge_delay = settings.get_int('edge-delay') | ||
| return edge_delay |
There was a problem hiding this comment.
get_trigger_size reads a setting 'edge-delay', perhaps this should be 'trigger-size'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Replaces #601
When sugar is run inside a window, the frame trigger is a very small
target to hit. This can be improved by making the trigger area bigger,
however it is only needed in some environments, not those where sugar
is fullscreen.
Ticket URL https://bugs.sugarlabs.org/ticket/4835