background control panel, alpha level callbacks #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gio.Settings changes are memory and processor expensive, because the instance persists until the change is flushed to disk. Extra changes were happening during button creation, and for every click of a button. By default, the first button is created active by Gtk+. When the code tries to set another button as active, the clicked callback for the first button is triggered. When followed by apply, this can lead to incorrect setting. Changes in this patch are to: - ignore callbacks for a button changing from active to inactive, by checking get_active(), - suppress callbacks during button creation, by connecting the toggled signal after the buttons have been created, - simplify the button creation code. Fixes #4912.
|
Reviewed, tested, and merged. |
tchx84
added a commit
that referenced
this pull request
Nov 12, 2015
background control panel, alpha level callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Gio.Settings changes are memory and processor expensive, because the instance persists until the change is flushed to disk.
Extra changes were happening during button creation, and for every click of a button. By default, the first button is created active by Gtk+. (See Gtk.RadioButton).
When the code tries to set another button as active, the clicked callback for the first button is triggered. When followed by apply, this can lead to incorrect setting.
Changes in this patch are to:
Fixes #4912.