Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability for change homeviews names #624

Merged
merged 1 commit into from Dec 20, 2015

Conversation

@ezequielpereira
Copy link
Contributor

ezequielpereira commented Dec 10, 2015

Before the GConf to Gsettings port changing the homeviews names
was possible.

This patch adds the ability to change it again using gsettings
config, "view-label".

How to test:
Follow the instruction for "gsettings instructions for Sugar 102+" in
https://wiki.sugarlabs.org/go/Features/Multiple_home_views
and add the key "view-label" to the homeview you want.

This is a GCI task:
https://codein.withgoogle.com/tasks/4788542454628352/

Before the GConf to Gsettings port changing the homeviews names
was possible.

This patch adds the ability to change it again using gsettings
config, "view-label".

How to test:
Follow the instruction for "gsettings instructions for Sugar 102+" in
https://wiki.sugarlabs.org/go/Features/Multiple_home_views
and add the key "view-label" to the homeview you want.
@i5o i5o added the feature label Dec 10, 2015
@i5o i5o self-assigned this Dec 10, 2015
@quozl

This comment has been minimized.

Copy link
Contributor

quozl commented Dec 11, 2015

Your test instructions are too complex. Reference to an already completed feature was confusing. There was no feature page for changing home view name. Please review and contribute to my simplified instructions in a new feature page. Also added to features page for 0.108.

@i5o

This comment has been minimized.

Copy link
Member

i5o commented Dec 14, 2015

I thought I replied this, but looks like I didn't.

You can use "Manage Home views" activity for add/remove homeviews, modify homeviews names, icons, etc. all with a graphical interface.

https://github.com/i5o/manage-homeviews

@samdroid-apps

This comment has been minimized.

Copy link
Member

samdroid-apps commented Dec 20, 2015

Yes, this is a good patch. One interesting thing is that while I can instantly add a homeview without restarting sugar, I must restart to see the name change come into effect.

@samdroid-apps samdroid-apps merged commit c5b0905 into sugarlabs:master Dec 20, 2015
@quozl

This comment has been minimized.

Copy link
Contributor

quozl commented Dec 20, 2015

@i5o, @samdroid-apps, yes, it would be better if restart is not needed, and also manage-homeviews should be brought into sugar as a control panel, not an activity.

@i5o

This comment has been minimized.

Copy link
Member

i5o commented Dec 20, 2015

I would work on the control panel thing as feature then.

I don't know if we have time (I mean, land for 0.108)

2015-12-20 19:28 GMT-03:00, James Cameron notifications@github.com:

@i5o, @samdroid-apps, yes, it would be better if restart is not needed, and
also manage-homeviews should be brought into sugar as a control panel, not
an activity.


Reply to this email directly or view it on GitHub:
#624 (comment)

Ignacio Rodríguez
SugarLabs at Facebook
https://www.facebook.com/pages/SugarLabs/187845102582

@samdroid-apps

This comment has been minimized.

Copy link
Member

samdroid-apps commented Dec 20, 2015

Yeah, I think that if you do a pretty restrained design we can definatly
get it merged!

On Mon, Dec 21, 2015 at 9:51 AM, Ignacio Rodríguez <notifications@github.com

wrote:

I would work on the control panel thing as feature then.

I don't know if we have time (I mean, land for 0.108)

2015-12-20 19:28 GMT-03:00, James Cameron notifications@github.com:

@i5o, @samdroid-apps, yes, it would be better if restart is not needed,
and
also manage-homeviews should be brought into sugar as a control panel,
not
an activity.


Reply to this email directly or view it on GitHub:
#624 (comment)

Ignacio Rodríguez
SugarLabs at Facebook
https://www.facebook.com/pages/SugarLabs/187845102582


Reply to this email directly or view it on GitHub
#624 (comment).

@quozl

This comment has been minimized.

Copy link
Contributor

quozl commented Dec 20, 2015

@i5o, that's a question for @tchx84 as release engineer. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.