Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added background for ViewSource's ImageBox #641

Merged
merged 1 commit into from
Dec 3, 2016
Merged

Added background for ViewSource's ImageBox #641

merged 1 commit into from
Dec 3, 2016

Conversation

ezequielpereira
Copy link
Contributor

@ezequielpereira
Added background for ViewSource's ImageBox
0500f1b 
* Added a grid background for ViewSource's ImageBox, so they are visible even when they are completely white
* This is a GCI 2015 task: https://codein.withgoogle.com/tasks/5721811266306048/
@ezequielpereira ezequielpereira mentioned this pull request Dec 22, 2015
Merged
@quozl
Copy link
Contributor

quozl commented Dec 22, 2015

Forgot to mention bug 4909, which contains an easy test case.

@ezequielpereira
Copy link
Contributor Author

Added to the description.

@quozl quozl added the bug label Dec 22, 2015
@quozl
Copy link
Contributor

quozl commented Nov 3, 2016

Thanks. Cherry-picked for OLPC builds. Don't see why this isn't merged by Sugar Labs.

@i5o
Copy link
Contributor

i5o commented Dec 3, 2016

Okay it does not work on fedora 25, maybe due to Gtk changes, but I'll merge it anyway.

@quozl reviewed, and it worked for me in older versions of fedora/gtk.

@i5o i5o merged commit 1538461 into sugarlabs:master Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezequielpereira @quozl @i5o