Fixed Ad-hoc icon mixup on the frame #642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ezequielpereira
commented
Dec 23, 2015
ezequielpereira
commented
- Non-Sugar Ad-hoc networks are shown like access points
- Fixes ticket 3006: https://bugs.sugarlabs.org/ticket/3006
- This is a GCI 2015 task: https://codein.withgoogle.com/tasks/6255669527183360/
|
Your commit message title is not descriptive, it should be "Show non-sugar ad-hoc networks as ad-hoc networks (not access points)" You also haven't addressed the issue where there are no icons for ad-hoc on channel 8, etc. |
|
My changes make the non-sugar ad-hoc networks appear just like normal access points, I don't think your title is suitable. |
* Non-Sugar Ad-hoc networks are shown like access points * Fixes ticket 3006: https://bugs.sugarlabs.org/ticket/3006 * This is a GCI 2015 task: https://codein.withgoogle.com/tasks/6255669527183360/
|
Cool, how should I test this then? |
|
Create an Ad-hoc network on channel 8 using another computer, then try to connect to it from Sugar. |
|
Can anyone test this? I only have one laptop for test :-/ |
|
Can be closed. Was already committed as b86b623. Tested, and does fix both issues in ticket 3006. |
|
Yay, thanks for responding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.