Journal multiselection try5 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2: Use a array to store the selected values
Don't store the metadata, with the selected uids is enough
Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
This checkbox is only available in the Journal, when the listview is used in the ObjectChooser the checkbox is not created. v2: Update by changes in the model. Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
Implement the changes to show the edit toolbar and the operations
'select all' and 'unselect all' only.
This version use the method find_ids in datastore, doing the operation
of select_all really fast.
Use a array in the model with the list of all the uids in the query, then is
not needed transverse the model to do the selection.
v2: Now the listmodel and the listview were cleaned as suggested
then this patch was simplified.
Fixed TRANS comment.
Replaced __redraw hack by the use of queue_draw.
Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
Now use a array of uids to know what copy instead of the object metadata, to make it compatible with the array of selected objects. The mount point is taken from the journal activity. Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
A new class CopyMenuBuilder is created to avoid duplicate code. CopyMenuBuilder can monitor mount/unmount of devices. Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
A confirmation is asked before start the operation, a can be canceled while is running. A object BatchOperator was added in palettes.py, and will be used to the copy batch operations too. Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
v2: The CopyMenuBuilder was implemented in another patch
then this is simpler.
Now the batch copy ignore objects without a file.
The menu in the case of the batch operation, does not include
a Clipboard option, because do not have much value copy
multiple objects to the clipboard.
Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
As the listmodel can be re created, due to events in the journal, or changes done by the user (title edition, favorite selection), the state of the selection should be preserved. Signed-of-by: Gonzalo Odiard <gonzalo@laptop.org>
Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
External devices appear multiple times when unplugging and plugging the device. Signed-off-by: Martin Abente Lahaye <tch@sugarlabs.org>
Select many objects in the Jurnal and send to a webservice can be a source of spam and be a reason to close a account. Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
|
Ready to go! |
tchx84
added a commit
that referenced
this pull request
Jul 24, 2013
Add support for multiselection in the Journal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Add two patches:
to avoid creating spam accidentally.