Fixed issue: Journal Entries can be renamed to blank via Detail View #663
Conversation
|
Hum, this changes worries me. While it prevents the user from changing the title to be nothing, it doesn't give them any feedback that the change has been prevented. Maybe that is something to look into if you wish to make this change? |
|
@samdroid-apps showing an alert message when the 'focus-out-event' signal is emitted would work. |
|
Yeah, you could do that |
devAbnull
force-pushed
the
detail_rename
branch
from
298e8b8
to
37b7483
Compare
|
An alert message added when the 'focus-out-event' signal is emitted and title box is empty. |
src/jarabe/journal/expandedentry.py
Outdated
| if new_title == '' or new_title.isspace(): | ||
| alert = Alert() | ||
| alert.props.title = _('Empty title') | ||
| alert.props.msg = 'The title cannot be empty' |
There was a problem hiding this comment.
Please put this string through gettext (_('...'))
devAbnull
force-pushed
the
detail_rename
branch
from
37b7483
to
a249701
Compare
|
@samdroid-apps Done! |
|
Looks good to me :) |
|
0.110.0 can still rename entries to blank in the detail view, when can we have this merged? |
|
Just tested. It kinda works and It kinda doesn't. Maybe I did something wrong! btw, a249701#diff-3f4b091ed74fd4c7f130a59dddba9bebR504 please check pep8 (add space after #) |
|
tested in sugar-build btw. |
|
ping x2! |
|
If @devAbnull is not available, feel free to diagnose and fix this yourself, and then make a new pull request with both their work and yours. On the other hand I'm still of the opinion that blank names should be allowed; see #4940. |
|
@devAbnull Ping |
|
See also #752 |
|
@i5o I couldn't replicate the issue :( |
|
Closed in favour of #949. |
Journal Entry can be renamed to blank when tried to rename via the Detail View.
Renaming directly from the list view was solved in #655.