Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drag_status call to work on fc24/23, fixes #4949 #666

Merged
merged 1 commit into from Jun 18, 2016

Conversation

samdroid-apps
Copy link
Contributor

I believe that Gdk.drag_status (new function) has been here forever (tested fc25, fc22), since it doesn't have an "new since" section in the docs [1].

[1] https://developer.gnome.org/gdk3/unstable/gdk3-Drag-and-Drop.html#gdk-drag-status

@quozl
Copy link
Contributor

quozl commented Mar 10, 2016

Applied on Fedora 18. How to test? (e.g. how to execute this code path?)

@samdroid-apps
Copy link
Contributor Author

Steps to reproduce:

  1. Open browse
  2. Start dragging SL logo
  3. Move cursor to top left to invoke frame

Expected: Frame shows

@quozl
Copy link
Contributor

quozl commented Mar 10, 2016

Thanks, that works; can now copy images to buffer in frame, could not before this patch.

Cherry-picked for my OLPC branch.

@samdroid-apps
Copy link
Contributor Author

Please merge if you have reviewed and tested the patch.

On Thu, Mar 10, 2016 at 4:03 PM, James Cameron
notifications@github.com wrote:

Thanks, that works; can now copy images to buffer in frame, could not
before this patch.

Cherry-picked for my OLPC branch.


Reply to this email directly or view it on GitHub.

@quozl
Copy link
Contributor

quozl commented Mar 10, 2016

I'm not of the opinion that there is sufficient peer review. It's early yet. Let's see what other developers think.

@davelab6
Copy link
Contributor

davelab6 commented Apr 4, 2016

Who else is needed to review and merge this 1 line change? :)

@quozl
Copy link
Contributor

quozl commented Apr 4, 2016

@davelab6, other reviewers would be @godiard, @tchx84, or some of the other people regularly involved in pull requests on this repository. Of the last ten merged pull requests, nine of them were merged by @samdroid-apps, and one by @godiard.

@davelab6 davelab6 mentioned this pull request Apr 5, 2016
@samdroid-apps samdroid-apps merged commit 400f24e into sugarlabs:master Jun 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants