Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webservice copy-to menu items #68

Merged
merged 1 commit into from Jul 26, 2013

Conversation

tchx84
Copy link
Member

@tchx84 tchx84 commented Jul 26, 2013

Retrieve metadata when populating the copy-to menu items
for webservices.

Pass metadata instead of the callback reference, to preserve
compatibility with current extensions.

Signed-off-by: Martin Abente Lahaye tch@sugarlabs.org

Retrieve metadata when populating the copy-to menu items
for webservices.

Pass metadata instead of the callback reference, to preserve
compatibility with current extensions.

Signed-off-by: Martin Abente Lahaye <tch@sugarlabs.org>
@tchx84
Copy link
Member Author

tchx84 commented Jul 26, 2013

@walterbender can you test it? :)

@walterbender walterbender merged commit 3eea2ce into sugarlabs:master Jul 26, 2013
@godiard
Copy link
Contributor

godiard commented Jul 26, 2013

I think is better modify the webservices.
Why? The palette is created every time, the user press the secondary button,
or is triggered by the time out, and you need do a query to the journal.
Is better do it only in the case the user decide use the webservice.

@walterbender
Copy link
Member

Ironically, that is how we first implemented the change :) Easy enough.

@tchx84
Copy link
Member Author

tchx84 commented Jul 26, 2013

I can revert this change. But, to take @godiard comment into account it will require to modify the webservices code (not only extensions) to actually use the callback in a on-demand manner.

@walterbender, @godiard What do you guys think? Should I proceed? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants