Start activity on single-clicking the corresponding row

[iamutkarshtiwari]

This patch add this requested feature -> https://bugs.sugarlabs.org/ticket/4919

Now the user can start an activity by just single clicking the row in the list view.

[samdroid-apps]

Nice patch, I like the new behaviour!

Just an issue that I found; if you click on the icon of the activity (with this patch), it is launched 3 times rather than just once. Maybe you can remove the icon clicked callbacks and just use the row-activated signal.

Also, you do not need the documentation for a 2 line callback function :) I appreciate your enthusiasm though.

[iamutkarshtiwari]

@samdroid-apps Documentation removed. Icon clicked callback removed. Patch rebased.

[devAbnull]

This would be cool. :)

And how about highlighting the row when mouse hovers over it?

[iamutkarshtiwari]

@AbrahmAB Nice idea! Working on it ;)

[iamutkarshtiwari]

Hover highlight selection added ;)

[samdroid-apps]

Looks good. I'm not a huge fan of the hover-to-highlight mode that you put it in though. It is very weird on a touch screen; it highlights the row as the cursor would be stuck at the start of the touch. It is hard to describe.

On another note, how do you make those very cool GIFs?

[iamutkarshtiwari]

@samdroid-apps If you don't like the highlight feature...I can remove it... ?

Those gifs have been fascinating a lot of people! :D
Here is where I found it : https://www.maketecheasier.com/record-screen-as-animated-gif-ubuntu/

[samdroid-apps]

Removing the highlight seems like a good plan for now. If you are
further interested in it, you could explore the edge cases with it and
touchscreens; and maybe try to patch it.

On Thu, Apr 21, 2016 at 7:28 AM, Utkarsh Tiwari
notifications@github.com wrote:

@samdroid-apps If you don't like the highlight feature...I can remove
it... ?

Those gifs have been fascinating a lot of people! :D
Here is where I found it :
https://www.maketecheasier.com/record-screen-as-animated-gif-ubuntu/

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

[iamutkarshtiwari]

Highlight feature removed.

[iamutkarshtiwari]

@samdroid-apps We need to unmerge this patch! Apologies. I didn't notice that clicking on star icon also starts the activity. I need to first find a solution to it...then we'll be good to go...until then we can leave it open.

[samdroid-apps]

Err, that's bad. I'll do it in the morning. Feel free just to submit a patch to fix the issue.

[iamutkarshtiwari]

I have found a solution. I am force pushing the commit (rebased) but still it's not showing up here?

[samdroid-apps]

Please send a new pull request from a new branch; hopefully that won't be too complex for dumb github's little brain.

[iamutkarshtiwari]

haha :D sure 👍