Password visibility toggle #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,10 +102,19 @@ def __init__(self, ssid, flags, wpa_flags, rsn_flags, dev_caps, response): | |||
|
|
|||
| def add_key_entry(self): | |||
| self._entry = Gtk.Entry() | |||
| self._entry.set_visibility(False) | |||
There was a problem hiding this comment.
You can just pass properties as constructor kwargs, eg:
self._entry = Gtk.Entry(visibility=False)
|
Looks good. I totally agree with the patch. Maybe we could default to it being visible? Visible is more usable :) In a school context, is the WiFi password really secret? I also think that windows 10 defaults to visible wifi passwords, but don't trust me on that. |
|
fixed. |
|
Great. I'll merge it! But can you just squash 'em commits? |
Now the user can toggle the password visible via 'show password' checkButton provided
iamutkarshtiwari
force-pushed
the
feature-ShowPasswordInWiressKeyInput
branch
from
11fcb77
to
dca2f17
Compare
|
Squashed. |
quozl
added a commit
to quozl/sugar
that referenced
this pull request
Jul 19, 2016
Password is invisible. Regression introduced in dca2f17. Consensus in pull request sugarlabs#693 was to show the password.
Merged
|
@iamutkarshtiwari, please review #703. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This fixes the issue - https://bugs.sugarlabs.org/ticket/4963
Now the user can toggle the password visiblility via 'show password' checkButton provided