Use find_icon_name method #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the find_icon_name method instead of repeating this search for volumes icons names all over. This patch solves the issue reported by Suraj. Volumes with GFileIcon icons caused Journal volumes toolbar, Journal copy-to menu items and Frame device icon to break. Signed-off-by: Martin Abente Lahaye <tch@sugarlabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Use the find_icon_name method instead of
repeating this search for volumes icons
names all over.
This patch solves the issue reported by
Suraj. Volumes with GFileIcon icons caused
Journal volumes toolbar, Journal copy-to
menu items and Frame device icon to break.
Signed-off-by: Martin Abente Lahaye tch@sugarlabs.org
This change depends on sugarlabs/sugar-toolkit-gtk3#26