About me - fix age picker spacing #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When language is set to Spanish, the icons do not appear evenly spaced. Each age is a Gtk.Grid containing an EventIcon and a Gtk.Label, but the array of grids is held in a Gtk.Fixed with spacing set by _configure method. The design depends on the label fitting within the large icon size of the style. Wrap and centre the label. This increases the chance that it will fit within the large icon size. Reported in https://bugs.sugarlabs.org/ticket/4967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When language is set to Spanish, the icons do not appear evenly spaced.
Each age is a Gtk.Grid containing an EventIcon and a Gtk.Label, but the array of grids is held in a Gtk.Fixed with spacing set by
_configuremethod. The design depends on the label fitting within the large icon size of the style.Wrap and centre the label. This increases the chance that it will fit within the large icon size.
Reported in https://bugs.sugarlabs.org/ticket/4967