Fix screen resize race #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callbacks are to be named according to the signal, or the purpose to which we put the signal. This callback was nearly named according to the signal. A similar callback is in sugar-toolkit-gtk3 and is correctly named.
When an external monitor is connected or disconnected, about 25% of the
time the Sugar shell does not resize correctly; a size-changed signal
occurs but the workarea geometry has not changed.
Underlying problem is an update race in get_monitor_workarea, so the fix
is to call get_monitor_geometry for obtaining the width and height, but
continue to use the workarea offset for the later call to self.move().
Can be reproduced easily without an external monitor by switching
display panel resolution repeatedly;
xrandr --output eDP1 --mode 1024x768
xrandr --output eDP1 --mode 1366x768
Part of a fix for https://bugs.sugarlabs.org/ticket/4968
|
Rebased to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When an external monitor is connected or disconnected, about 25% of the time the Sugar shell does not resize correctly; a
size-changedsignal occurs but the workarea geometry has not changed.Underlying problem is an update race in
get_monitor_workarea, so the fix is to callget_monitor_geometryfor obtaining the width and height, but continue to use the workarea offset for the later call toself.move().Can be reproduced easily without an external monitor by switching display panel resolution repeatedly;
Part of a fix for https://bugs.sugarlabs.org/ticket/4968
Rename size changed callback. Callbacks are to be named according to the signal, or the purpose to which we put the signal. This callback was nearly named according to the signal. A similar callback is in sugar-toolkit-gtk3 and is correctly named.
Related pull request sugarlabs/sugar-toolkit-gtk3#343 can be merged in any order with this pull request; the patches are independent but solve the same problem in two different contexts.