ShellModel: set is_main_window when home_activity is None - #4602 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 58fa64 we forgot to set it in that case. home_activity will be None at least for the Journal. The code in shell.py is not the best, so we don't have another option than duplicating the code in both parts of the conditional. This fixes the Journal icon in the frame that was pulsing all the time.
|
Superseded by #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In commit 58fa64 we forgot to set it in that case. home_activity will
be None at least for the Journal. The code in shell.py is not the
best, so we don't have another option than duplicating the code in
both parts of the conditional.
This fixes the Journal icon in the frame that was pulsing all the
time.