New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library not working #31

Closed
marijaantic opened this Issue Oct 29, 2018 · 5 comments

Comments

Projects
None yet
6 participants
@marijaantic
Copy link

marijaantic commented Oct 29, 2018

Bug noticed on live demo: https://sugarshin.github.io/react-instagram-embed/

@yu-imu

This comment has been minimized.

Copy link

yu-imu commented Oct 29, 2018

My application is also faced this bug.
This bug may be caused by CORB.

search console
screen shot 2018-10-28 at 22 59 50

But I can't fix....

@hendra-go

This comment has been minimized.

Copy link

hendra-go commented Oct 30, 2018

Yup, i also experienced this problem.
Probably because of the callback ?

in firefox if you access directly

https://api.instagram.com/oembed/?hidecaption=false&maxwidth=320&omitscript=true&url=https%3A%2F%2Finstagr.am%2Fp%2FZw9o4%2F

without the callback, it correctly return js object.

but if you also include the callback like
https://api.instagram.com/oembed/?hidecaption=false&maxwidth=320&omitscript=true&url=https%3A%2F%2Finstagr.am%2Fp%2FZw9o4%2F&callback=__jp0,

it return SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data

@hugovk

This comment has been minimized.

Copy link

hugovk commented Oct 30, 2018

Here's a PR to fix it: #32.

@JokinenK

This comment has been minimized.

Copy link
Contributor

JokinenK commented Oct 31, 2018

Before this PR gets merged or bug fixed in some other way, here is easy way to test the PR's changes out:

npm install --save git+https://github.com/JokinenK/react-instagram-embed#release/1.4.0_json

or

yarn add git+https://github.com/JokinenK/react-instagram-embed#release/1.4.0_json

Edit: The branch release/1.4.0_json only contains transpiled files created using npm run compile.

@sugarshin

This comment has been minimized.

Copy link
Owner

sugarshin commented Nov 4, 2018

I solved and released new version.

@sugarshin sugarshin closed this Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment