Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task to build browser scripts #4

Merged
merged 5 commits into from Feb 16, 2017

Conversation

Projects
None yet
2 participants
@thammin
Copy link
Collaborator

commented Feb 15, 2017

  • add setImmediate polyfill for browser.
  • add build.js to build scripts for browser.

btw, maybe we should add a benchmark for browser script since we are using setImmediate polyfill as fallback.

README.md Outdated
```

```js
var Promise = require('aigle');

This comment has been minimized.

Copy link
@suguru03

suguru03 Feb 15, 2017

Owner

Could you change var to const?

index.js Outdated
@@ -1,3 +1,4 @@
'use strict';

require('setimmediate');

This comment has been minimized.

Copy link
@suguru03

suguru03 Feb 15, 2017

Owner

This index.js is main root, the library should be in dependencies.
But I don't want to add it to dependencies, is it possible to use another main root to build?

This comment has been minimized.

Copy link
@thammin

thammin Feb 16, 2017

Author Collaborator

You are right, should just include the polyfill when doing bundling.

@suguru03
Copy link
Owner

left a comment

Thanks for PR!
Could you check the review?

build.js Outdated
@@ -0,0 +1,21 @@
const fs = require('fs');
const exec = require('child_process').exec;

This comment has been minimized.

Copy link
@suguru03

suguru03 Feb 15, 2017

Owner

I prefer const { exec } = require('child_process'); 😄

@suguru03 suguru03 merged commit 8a88f90 into suguru03:master Feb 16, 2017

1 check failed

ci/circleci Your tests failed on CircleCI
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.