Make Value fully constructible#171
Merged
suharev7 merged 1 commit intosuharev7:async-awaitfrom May 5, 2022
Merged
Conversation
Previous implementation of the `Value` enum used a hand-crafted `Either` enum in order to represent values that can either be null (the `Left` variant) or non-null value (the `Right`) variant. The problem is that this enum was not exposed in the public API. As such, it was impossible for `clickhouse_rs` users to build `Value::Nullable(...)` values. This commit fixes the problem by removing the `Either` datatype from the codebase and using the [`either`] crate instead, hence making every variant of `Value` constructible! [`either`]: https://docs.rs/either/1.6.1/either/index.html
Owner
|
Thank a lot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous implementation of the
Valueenum used a hand-craftedEitherenum in order to represent values that can either be null (the
Leftvariant) or non-null value (the
Right) variant.The problem is that this enum was not exposed in the public API. As
such, it was impossible for
clickhouse_rsusers to buildValue::Nullable(...)values.This commit fixes the problem by removing the
Eitherdatatype from thecodebase and using the
eithercrate instead, hence making everyvariant of
Valueconstructible!