Compare IP adresses properly #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of `PartialEq` for `Value` is handcrafted. It is composed of a huge `match` expression, which aims to properly compare each variant of the left-hand and the right-hand `Values`. The last arm is a catchall arm, supposed to catch every case where both variant does not match. The problem is that no match arm in the said expression handles the `Ipv4`, `Ipv6` and `Uuid` variants. As such, two IP addresses are always considered as not equal. Similarly, two UUIDs are always considered as not equal. This commit adds three missing arms, which adds proper IP address comparison as well as proper UUID comparison.
scrabsha
force-pushed
the
scrabsha/compare-ip-addresses
branch
from
53d5801
to
2ade71f
Compare
|
Thank you |
scrabsha
added a commit
to scrabsha/clickhouse-rs
that referenced
this pull request
May 17, 2022
The problem here is similar to what is descibed at [1]: the implementation of `PartialEq` for `Value` doesn't try to handle the `DateTime64` variant. This commit adds the corresponding match arm and actually performs the equality check. [1]: suharev7#172
scrabsha
added a commit
to scrabsha/clickhouse-rs
that referenced
this pull request
May 17, 2022
The problem here is similar to what is descibed at [1]: the implementation of `PartialEq` for `Value` doesn't try to handle the `Enum8` and `DateTime64` variant. This commit adds the corresponding match arms and actually performs the equality checks. [1]: suharev7#172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare IP adresses and UUID properly
The implementation of
PartialEqforValueis handcrafted. It iscomposed of a huge
matchexpression, which aims to properly compareeach variant of the left-hand and the right-hand
Values. The last armis a catchall arm, supposed to catch every case where both variant does
not match.
The problem is that no match arm in the said expression handles the
Ipv4,Ipv6andUuidvariants. As such, two IP addresses are alwaysconsidered as not equal. Similarly, two UUIDs are always considered as
not equal.
This commit adds three missing arms, which adds proper IP address
comparison as well as proper UUID comparison.