From 38a109e777f9b1a92ac21e71b679bc345e58ee61 Mon Sep 17 00:00:00 2001 From: Reed Anderson <5388349+reedanders@users.noreply.github.com> Date: Tue, 27 Oct 2020 19:14:58 -0400 Subject: [PATCH] [docs] Fix a few typos and add comma (#23284) --- CONTRIBUTING.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6d8ce2dd4322f2..e0390b40022a0e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -89,7 +89,7 @@ Make sure the following is true: - When submitting a new component, please add it to the [lab](https://github.com/mui-org/material-ui/tree/HEAD/packages/material-ui-lab). - The branch is not behind its target. -Because we will only merge a Pull Request for which all tests pass. The following items need is true. We will provide assistance if not: +Because we will only merge a Pull Request for which all tests pass. The following items need to be true. We will provide assistance if not: - If TypeScript declarations were changed, `yarn typescript` passed. - The code is formatted (run `yarn prettier`). @@ -156,7 +156,7 @@ or `yarn docs:export` usually fail locally as well. This task is mostly responsible for monitoring the bundle size. It will only report the size if the change exceeds a certain threshold. If it fails there's usually -something wrong with the how the packages or docs were built. +something wrong with the way the packages or docs were built. #### codecov/project @@ -178,7 +178,7 @@ is why it is disabled when tests are run locally by default. The rationale being that in almost all cases including or excluding elements from a query-set depending on their a11y-tree membership makes no difference. The queries where this does make a difference explicitly include this check e.g. `getByRole('button', { hidden: false })` (see [byRole documentation](https://testing-library.com/docs/dom-testing-library/api-queries#byrole) for more information). -To see if your test (`test:browser` or `test:unit`) behaves the same between CI and local environment set the environment variable `CI` to `'true'`. +To see if your test (`test:browser` or `test:unit`) behaves the same between CI and local environment, set the environment variable `CI` to `'true'`. ### Trying the changes on the documentation site @@ -257,7 +257,7 @@ Material-UI documents how to use this library with TypeScript. If you are familiar with this language, write the demo in TypeScript, and only, in a \*.tsx file. When you're done run `yarn docs:typescript:formatted` to automatically create the JavaScript version. -If you are no familiar with that language, write the demo in JavaScript, a core contributor might help you to migrate it to TypeScript. +If you are not familiar with that language, write the demo in JavaScript, a core contributor might help you to migrate it to TypeScript. #### 4. You are done 🎉!