Adds redis queueing of next steps. #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinlittman
commented
May 3, 2019
app/controllers/steps_controller.rb
Outdated
| # TODO: Do we only want to do this for certain updates, e.g., when setting status to completed? | ||
| # Enqueue next steps | ||
| next_steps = NextStepService.for(step: step) | ||
| next_steps.each { |next_step| Queue.enqueue(next_step) } |
Contributor
Author
There was a problem hiding this comment.
Are there some steps that we don't want to enqueue?
Contributor
There was a problem hiding this comment.
Yes, if the template has skipQueue as an attribute I don't think we want to enqueue it. I think NextStepService is only returning things that can be queued though: https://github.com/sul-dlss/workflow-server-rails/blob/master/app/services/next_step_service.rb#L28
jcoyne
reviewed
May 3, 2019
Gemfile
Outdated
| gem 'dor-services-client', '~> 1.2' | ||
| gem 'honeybadger', '~> 4.1' | ||
| gem 'jbuilder', '~> 2.5' | ||
| gem 'lyber-core', '>= 4.0.3' |
Contributor
There was a problem hiding this comment.
Do you think we can inline the one function rather than pull in lyber-core? Lyber-core is another dependency I'd like to kill off.
|
|
||
| def current_version | ||
| ObjectVersionService.current_version(params[:druid]) | ||
| # Providing the version as a param is for local testing without needing to run DOR services. |
Contributor
There was a problem hiding this comment.
I'd like us to move to this pattern in production too.
justinlittman
force-pushed
the
robots
branch
2 times, most recently
from
98a4636 to
3dc0a9c
Compare
jcoyne
approved these changes
May 8, 2019
jcoyne
requested changes
May 8, 2019
docker-compose.yml
Outdated
| # - RAILS_ENV=development | ||
| - SETTINGS__ENABLE_STOMP=false | ||
| - SETTINGS__REDIS__HOSTNAME=redis | ||
| # image: 'suldlss/workflow-server:latest-dev' |
Contributor
There was a problem hiding this comment.
remove these commented out lines
jcoyne
approved these changes
May 8, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.