Removes defunct resource editing functionality #565
Conversation
|
Well I'm glad we attended to that XXX spec and resolved to remove all this. I suggest a patch to keep all this stuff get thrown into a branch that may go stale. |
|
Can you elaborate on your suggestion about the patch and branch? I'm not sure I follow a 💯% |
|
When this thing is good to go, merge it, create a new branch, reset and commit to that branch. I guess that will thereby keep everything thrown away in a tidy form at the time it was thrown away. With a branch name on it, it should be easier to find than trolling through commits? Anyhow, no big deal. |
|
👍 (although I don't know much about these features and whether they would be easy to complete rather than throw them away). |
|
Ah gotcha good call. Just created #566 which references the SHA and this PR so we can dig it up later on. |
| <%if can_manage && version_open | ||
| edit_resource_link="/items/#{params[:id]}/resource/?edit=true&resource=#{resource['id']}"%> | ||
| <%= link_to "(edit)", edit_resource_link, :data => {ajax_modal: 'trigger'} %> | ||
| <%end%> |
There was a problem hiding this comment.
The version_open = can_close_version? object.pid statement can also be deleted, right?
There was a problem hiding this comment.
Thanks for catching that @drh-stanford ! Just pushed a change removing that.
This commit removes legacy and non-working resource editing functionality. This functionality is broken and if needed, should be rewritten accordingly with updated patterns.
mejackreed
force-pushed
the
remove-resource
branch
from
c7f72ab
to
0c30f4e
Compare
Removes defunct resource editing functionality
|
This PR strictly removes code from the unused resource (file) management UIs. |
This commit removes legacy and non-working resource editing functionality. This functionality is broken and if needed, should be rewritten accordingly with updated patterns.
Closes #523
I hope this can also reduce some complexity and comments on #516 and the various APO related changes PR's by @darrenleeweber .