From c732a051f2e8259bdffb7149c03a5162252255ba Mon Sep 17 00:00:00 2001 From: Jessie Keck Date: Tue, 8 Sep 2020 09:45:24 -0700 Subject: [PATCH] Don't use rubocop-rails 2.8.0 as it introduces a bug. rubocop-hq/rubocop-rails#349 will hopefully address this in the next release --- Gemfile | 3 ++- Gemfile.lock | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Gemfile b/Gemfile index 799a3e2a..588fc4ed 100644 --- a/Gemfile +++ b/Gemfile @@ -47,7 +47,8 @@ group :development, :test do gem 'rails-controller-testing' gem 'rubocop', '~> 0.65' gem 'rubocop-performance' - gem 'rubocop-rails' + # Don't use rubocop-rails 2.8.0 (it has a bug that fails our builds) + gem 'rubocop-rails', '> 2.7', '!= 2.8.0' gem 'rubocop-rspec' gem 'solr_wrapper' gem 'webdrivers' diff --git a/Gemfile.lock b/Gemfile.lock index 72f5b89c..9e85b316 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -472,7 +472,7 @@ GEM parser (>= 2.7.1.4) rubocop-performance (1.8.0) rubocop (>= 0.87.0) - rubocop-rails (2.8.0) + rubocop-rails (2.7.1) activesupport (>= 4.2.0) rack (>= 1.1) rubocop (>= 0.87.0) @@ -649,7 +649,7 @@ DEPENDENCIES rspec_junit_formatter rubocop (~> 0.65) rubocop-performance - rubocop-rails + rubocop-rails (> 2.7, != 2.8.0) rubocop-rspec sass-rails (~> 5.0) selenium-webdriver