From 253c9bff094dc751af02bca60b57c704b960b812 Mon Sep 17 00:00:00 2001 From: Justin Coyne Date: Tue, 21 May 2019 08:33:14 -0500 Subject: [PATCH] Notifiy honeybadger when someone passes the deprecated initiate_workflow parameter --- app/models/registration_request.rb | 2 +- app/services/registration_service.rb | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/models/registration_request.rb b/app/models/registration_request.rb index 6acedad4b..05697cae6 100644 --- a/app/models/registration_request.rb +++ b/app/models/registration_request.rb @@ -16,7 +16,7 @@ class RegistrationRequest # @option params [String] :pid Fully qualified PID if you don't want one generated for you # @option params [Integer] :workflow_priority] # @option params [Array] :seed_datastream datastream_names (only 'descMetadata' is a permitted value) - # @option params [Array] :initiate_workflow workflow_ids + # @option params [Array] :initiate_workflow workflow_ids this parameter is deprecated # @option params [Array] :tags def initialize(params) @params = params diff --git a/app/services/registration_service.rb b/app/services/registration_service.rb index 363c728b8..6813af668 100644 --- a/app/services/registration_service.rb +++ b/app/services/registration_service.rb @@ -134,6 +134,8 @@ def ids_to_hash(ids) end def initiate_workflow(workflows:, item:, priority:) + Honeybadger.notify("RegistrationService received deprecated parameter `initiate_workflow' with: `#{workflows.inspect}'") if workflows.present? + workflows.each do |workflow_id| Dor::Config.workflow.client.create_workflow_by_name(item.pid, workflow_id, priority: priority) end