From 2ed22af6ae2d86e855a03bea69701dedb191c6b4 Mon Sep 17 00:00:00 2001 From: Naomi Dushay Date: Mon, 9 Sep 2019 17:59:48 -0700 Subject: [PATCH] rescue SymphonyReader::ResponseError in controllers --- app/controllers/marcxml_controller.rb | 2 +- app/controllers/metadata_refresh_controller.rb | 2 +- app/controllers/objects_controller.rb | 2 +- spec/requests/register_object_spec.rb | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/controllers/marcxml_controller.rb b/app/controllers/marcxml_controller.rb index 466395e5d..a5651ba61 100644 --- a/app/controllers/marcxml_controller.rb +++ b/app/controllers/marcxml_controller.rb @@ -3,7 +3,7 @@ class MarcxmlController < ApplicationController #:nodoc: before_action :set_marcxml_resource - rescue_from(SymphonyReader::RecordIncompleteError) do |e| + rescue_from(SymphonyReader::ResponseError) do |e| render status: :internal_server_error, plain: e.message end diff --git a/app/controllers/metadata_refresh_controller.rb b/app/controllers/metadata_refresh_controller.rb index 730b3b6d1..58aa9cfe8 100644 --- a/app/controllers/metadata_refresh_controller.rb +++ b/app/controllers/metadata_refresh_controller.rb @@ -4,7 +4,7 @@ class MetadataRefreshController < ApplicationController before_action :load_item - rescue_from(SymphonyReader::RecordIncompleteError) do |e| + rescue_from(SymphonyReader::ResponseError) do |e| render status: :internal_server_error, plain: e.message end diff --git a/app/controllers/objects_controller.rb b/app/controllers/objects_controller.rb index ad8667ba2..edff9932d 100644 --- a/app/controllers/objects_controller.rb +++ b/app/controllers/objects_controller.rb @@ -19,7 +19,7 @@ class ObjectsController < ApplicationController render status: :internal_server_error, plain: e.message end - rescue_from(SymphonyReader::RecordIncompleteError) do |e| + rescue_from(SymphonyReader::ResponseError) do |e| render status: :internal_server_error, plain: e.message end diff --git a/spec/requests/register_object_spec.rb b/spec/requests/register_object_spec.rb index e9aea266e..1d35b8c8e 100644 --- a/spec/requests/register_object_spec.rb +++ b/spec/requests/register_object_spec.rb @@ -41,7 +41,7 @@ let(:errmsg) { 'my unique snowflake error message' } before do - allow(RegistrationService).to receive(:register_object).and_raise(SymphonyReader::RecordIncompleteError.new(errmsg)) + allow(RegistrationService).to receive(:register_object).and_raise(SymphonyReader::ResponseError.new(errmsg)) end it 'returns a 500 error' do