Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally support cocina lookup #442

Merged
merged 2 commits into from Oct 9, 2020
Merged

Optionally support cocina lookup #442

merged 2 commits into from Oct 9, 2020

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Oct 8, 2020

Why was this change made?

This will allow us to use cocina model if it exists. Using dry-monads to show that we have to check for its value until we have consitent conformant data

How was this change tested?

Tested on stage.

Which documentation and/or configurations were updated?

This will allow us to use cocina model if it exists.  Using dry-monads to show that we have to check for its value until we have consitent conformant data
Copy link
Member

@mjgiarlo mjgiarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I understand this has been getting tested on stage

@mjgiarlo mjgiarlo merged commit 87f472e into master Oct 9, 2020
@mjgiarlo mjgiarlo deleted the optional-cocina branch October 9, 2020 15:15
jcoyne added a commit to sul-dlss/argo that referenced this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants