Permalink
Commits on Oct 20, 2016
  1. Merge pull request #32 from sul-dlss/fix-purl-url

    fix purl url from http to https
    atz committed on GitHub Oct 20, 2016
Commits on Sep 28, 2016
  1. fix purl url from http to https

    peetucket committed Sep 28, 2016
Commits on Nov 12, 2015
  1. Merge pull request #24 from sul-dlss/purl

    Update Hydrus to check PURL over HTTPS
    atz committed Nov 12, 2015
  2. Update Hydrus to check PURL over HTTPS

    cbeer committed Nov 12, 2015
Commits on Jun 29, 2015
  1. Merge pull request #18 from sul-dlss/dev_updates

    Dev updates
    atz committed Jun 29, 2015
  2. Regenerated lock file clean

    atz committed Jun 29, 2015
  3. Distinguish between tests

    atz committed Dec 9, 2014
  4. Improve error reporting

    Replace cannot_do() with cannot_do_message().  Raise in each of the
    dependent classes directly.
    
    See: Jira ticket HYDRUS-340
    atz committed Dec 9, 2014
  5. updated example

    atz committed Dec 8, 2014
  6. Abide by Rspec requirements

    The use of doubles or partial doubles from rspec-mocks outside of the
    per-test lifecycle is not supported.
    
    And it is just two tests, so no big deal.
    
    Now the tests fail differently.
    atz committed Dec 6, 2014
  7. Simplest standalone mock_authed_user spec

    Made for ease of single-file execution
    atz committed Dec 5, 2014
  8. DRY up collection handling, also fix NIL error

    Previously we were attempting to call .first on NIL.
    Arguably identityMetadata_objectId_t should always be populated, but
    in practice during testing it was not.  #dealwithit
    atz committed Dec 5, 2014
  9. Add one space

    Yes this is trivial.
    atz committed Dec 5, 2014
  10. Deprecate rspec_with_integration

    Prefer rspec_integration.
    
    In actuality none of these tasks should exist.  They are all silly
    "efficiencies" around just doing:
     rspec --tag=integration
       or
     rspec --tag=~integration
    atz committed Dec 4, 2014
  11. Cut number of integration failures in half

    On ruby 1.9.3-p547, for 'rake rspec_with_integration'
    Was: 120 examples, 90 failures, 1 pending
    Now: 120 examples, 45 failures, 1 pending
    
    The errors fixed were of the form:
    NoMethodError:
      undefined method `visit' for #<RSpec::ExampleGroups::ItemEdit:0x007fe082ba3a28>
    atz committed Dec 4, 2014
  12. Move DEFAULT_OPTS for rake/spec to .rspec

    Also properly define the "all" case.
    
    No random test order
    
    once everything is passing, we can put this back in if needed
    atz committed Dec 4, 2014
  13. Bumping versions on deps

    dor-services
    equivalent-xml
    moab-versioning
    capistrano
    rake
    etc
    atz committed Dec 4, 2014
  14. Readability matters

    Separate out our Stanford-local stuff from general ruby deps.
    Use single quotes uniformly.
    Bump capistrano version, just because.
    atz committed Dec 3, 2014
  15. Make equivalent-xml work in spec_helper

    For ruby 2.1, to avoid errors like:
    
    Failure/Error: expect(@dsdoc.ng_xml).to be_equivalent_to <<-EOF
    expected <?xml version="1.0"?>
      <mods xmlns="http://www.loc.gov/mods/v3">
      <subject><topic>foo</topic></subject><subject><topic>bar</topic></subject><subject><topic>quux</topic>
      </subject></mods>
    to respond to `equivalent_to?`
    
    Account for equivalent-xml dependency
    atz committed Dec 3, 2014
  16. bcrypt-ruby is now just bcrypt

    From post-install message:
      The bcrypt-ruby gem has changed its name to just bcrypt.  Instead of
    installing `bcrypt-ruby`, you should install `bcrypt`.  Please update
    your dependencies accordingly.
    atz committed Dec 3, 2014
  17. Minor cleanup

    Developers need to run tests!  There are very few dependencies for a
    test environment that are not part of the dev env also.
    atz committed Dec 2, 2014
  18. Step up to newer version of rspec

    Semantic versioning, engage!
    atz committed Nov 27, 2014
  19. Ran transpec

    Summary:
    
    1289 conversions
      from: obj.should
        to: expect(obj).to
    922 conversions
      from: == expected
        to: eq(expected)
    350 conversions
      from: obj.stub(:message)
        to: allow(obj).to receive(:message)
    103 conversions
      from: obj.should_not
        to: expect(obj).not_to
    65 conversions
      from: obj.should_receive(:message)
        to: expect(obj).to receive(:message)
    43 conversions
      from: =~ /pattern/
        to: match(/pattern/)
    36 conversions
      from: obj.should_not_receive(:message)
        to: expect(obj).not_to receive(:message)
    25 conversions
      from: describe 'some model' { }
        to: describe 'some model', :type => :model { }
    20 conversions
      from: obj.stub_chain(:message1, :message2)
        to: allow(obj).to receive_message_chain(:message1, :message2)
    18 conversions
      from: be_true
        to: be_truthy
    16 conversions
      from: be_false
        to: be_falsey
    6 conversions
      from: describe 'some controller' { }
        to: describe 'some controller', :type => :controller { }
    5 conversions
      from: describe 'some feature' { }
        to: describe 'some feature', :type => :feature { }
    5 conversions
      from: obj.stub(:message => value)
        to: allow(obj).to receive_messages(:message => value)
    3 conversions
      from: > expected
        to: be > expected
    3 conversions
      from: expect(collection).to have(n).items
        to: expect(collection.size).to eq(n)
    2 conversions
      from: Klass.any_instance.stub(:message)
        to: allow_any_instance_of(Klass).to receive(:message)
    2 conversions
      from: describe 'some helper' { }
        to: describe 'some helper', :type => :helper { }
    1 conversion
      from: describe 'some mailer' { }
        to: describe 'some mailer', :type => :mailer { }
    1 conversion
      from: lambda { }.should_not
        to: expect { }.not_to
    
    2915 conversions, 1 incomplete, 17 warnings, 0 errors
    
    I think these are ok.
    WARNINGS:
    
    The `=~ @edit_path_regex` has been converted but it might possibly be
    incorrect due to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/collection_create_spec.rb:34:    current_path.should =~ @edit_path_regex
    
    The `=~ exp` has been converted but it might possibly be incorrect due
    to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/collection_create_spec.rb:81:      e.text.should =~ exp
    
    The `=~ @edit_path_regex` has been converted but it might possibly be
    incorrect due to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/collection_create_spec.rb:98:    current_path.should =~ @edit_path_regex
    
    The `=~ exp` has been converted but it might possibly be incorrect due
    to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/collection_create_spec.rb:209:    es[0...exp.size].zip(exp).each { |e, exp| e.text.should =~ exp  }
    
    The `=~ @edit_path_regex` has been converted but it might possibly be
    incorrect due to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/item_create_spec.rb:52:        current_path.should =~ @edit_path_regex
    
    The `=~ @edit_path_regex` has been converted but it might possibly be
    incorrect due to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/item_create_spec.rb:61:        current_path.should =~ @edit_path_regex
    
    The `=~ @edit_path_regex` has been converted but it might possibly be
    incorrect due to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/item_create_spec.rb:70:    current_path.should =~ @edit_path_regex
    
    The `=~ exp` has been converted but it might possibly be incorrect due
    to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/item_create_spec.rb:103:      e.text.should =~ exp
    
    The `=~ @edit_path_regex` has been converted but it might possibly be
    incorrect due to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/item_create_spec.rb:113:    current_path.should =~ @edit_path_regex
    
    The `=~ @edit_path_regex` has been converted but it might possibly be
    incorrect due to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/item_create_spec.rb:137:    current_path.should =~ @edit_path_regex
    
    The `=~ @edit_path_regex` has been converted but it might possibly be
    incorrect due to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/item_create_spec.rb:181:    current_path.should =~ @edit_path_regex
    
    The `=~ exp` has been converted but it might possibly be incorrect due
    to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/item_create_spec.rb:370:    es[0...exp.size].zip(exp).each{ |e, exp| e.text.should =~ exp  }
    
    The `=~ @edit_path_regex` has been converted but it might possibly be
    incorrect due to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/item_create_spec.rb:394:    current_path.should =~ @edit_path_regex
    
    The `=~ exp` has been converted but it might possibly be incorrect due
    to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/item_create_spec.rb:489:    es[0...exp.size].zip(exp).each{ |e, exp| e.text.should =~ exp  }
    
    The `have(1).item` has been converted but it might possibly be incorrect
    due to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/models/collection_spec.rb:35:expect(coll.events.event.val).to have(1).item
    
    Cannot convert #stub into #allow since #allow is not available in the context.
    spec/features/models/item_spec.rb:85: Dor::WorkflowDs.any_instance.stub(:current_priority).and_return 0
    
    The `have(1).item` has been converted but it might possibly be incorrect
    due to a lack of runtime information. It's recommended to review the change carefully.
    spec/features/models/item_spec.rb:112:   expect(item.events.event.val).to have(1).item
    
    The `=~ rgx` has been converted but it might possibly be incorrect due
    to a lack of runtime information. It's recommended to review the change carefully.
    spec/spec_helper.rb:201:  current_path.should =~ rgx
    atz committed Nov 26, 2014
  20. update from insecure version of rails

    require by bundle audit for deployment
    atz committed Nov 26, 2014
  21. Merge branch 'develop'

    atz committed Jun 29, 2015
  22. Minor dependency bumps

    atz committed Jun 29, 2015
Commits on Jun 27, 2015
  1. More readme conversion fixes.

    atz committed Jun 27, 2015
  2. Fix links (no associated images)

    atz committed Jun 27, 2015
  3. Tune up converted README

    dor-services is now public.  Add formatting and make links links.
    atz committed Jun 27, 2015
  4. Unnecessary .gitkeep files

    atz committed Jun 27, 2015