Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test accessibility of LibCal space booking #2

Closed
anarchivist opened this issue Jul 14, 2022 · 6 comments
Closed

Test accessibility of LibCal space booking #2

anarchivist opened this issue Jul 14, 2022 · 6 comments
Assignees

Comments

@anarchivist
Copy link
Contributor

anarchivist commented Jul 14, 2022

SUL wants to go live with LibCal for group study room booking in Green, ideally by July 29, 2022. We need to undertake accessibility testing of this feature. I believe the pages we will need to test are the following:

The best recommendation I can follow is to look at the past accessibility analysis that Camille did in August 2021, which used the following methods:

  • WCAG compliance checking browser extensions (axe, Lighthouse, Firefox Accessibility Inspector)
  • Manual audit screenreader audit (Mac VoiceOver)
  • Manual keyboard navigation check
@anarchivist anarchivist added help wanted Extra attention is needed accessibility labels Jul 14, 2022
@thatbudakguy thatbudakguy self-assigned this Jul 14, 2022
@thatbudakguy thatbudakguy removed the help wanted Extra attention is needed label Jul 15, 2022
@thatbudakguy
Copy link
Member

thatbudakguy commented Jul 15, 2022

added comments to Camille's analysis, but here's a quick breakdown of the two major issues.

  1. Primary buttons don't have a focus style. this is a WCAG violation and makes it difficult for sighted keyboard users to submit reservation forms. This affects all pages that have primary buttons. Fortunately, it's an easy fix — we are explicitly disabling the focus style on these buttons in our CSS currently, so we just need to set a focus style. Probably good to get a designer's take, but in the meantime we can do something simple but functional. Relevant CSS here:

libapps/libcal/head.html

Lines 166 to 182 in 474cded

.btn-primary,
.btn-primary.focus,
.btn-primary:focus,
.btn-primary.active,
.btn-primary:active,
.open>.dropdown-toggle.btn-primary,
.btn-primary.active.focus,
.btn-primary.active:focus,
.btn-primary:active.focus,
.btn-primary:active:focus,
.open>.dropdown-toggle.btn-primary.focus,
.open>.dropdown-toggle.btn-primary:focus,
.btn-info {
background-color: #8c1515 !important;
border: none !important;
outline: none !important;
}

  1. The booking widget is not keyboard accessible. no one other than sighted mouse users can interact with this widget, which shows up on the library landing page and individual space booking page. It isn't quite game-over, though, because the "accessible version" of the booking experience works fine for both SRs and keyboard users. The only issue is that sighted keyboard users probably won't know to click the "version of this page for screen readers" link and will be frustrated when they can't initially access the booking widget. This link text should be updated so it's more obvious that keyboard users need to go to this page, too. I think this is a SpringShare thing; not sure what their bandwidth to address it is.

screenshot of libcal booking widget

there's a few other minor issues, but nothing that is a blocker to access, and nothing that screen reader users aren't likely used to dealing with elsewhere.

@anarchivist
Copy link
Contributor Author

anarchivist commented Jul 15, 2022

Thanks! I know @astridu was working on the room booking part of the LibCal implementation in part, so could you perhaps pair with her to investigate the focus style?

I can submit the feedback to Springshare on the second issue, but it may not get resolved in time for us to launch.

@anarchivist
Copy link
Contributor Author

@thatbudakguy I went ahead and submitted a Springshare ticket on the "screen reader version" link text, as well as the logout button on reservation confirmation page as tab-navigable and the unlabeled fieldset on the confirmation part of booking.

If you follow up with Astrid and think this is otherwise good to go, let me know and close this issue.

@thatbudakguy
Copy link
Member

got some help from Gary on applying the new focus style and addressed everything on our side, so closing this.

@anarchivist
Copy link
Contributor Author

@anarchivist
Copy link
Contributor Author

Just to confirm, these changes have now been implemented in LibCal. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants