Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package.json to assets folder #196

Merged
merged 6 commits into from Aug 28, 2019

Conversation

@danrot
Copy link
Member

danrot commented Aug 28, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets ---
Related issues/PRs sulu/sulu#4708
License MIT
Documentation PR ---

What's in this PR?

This PR will move the package.json along with other configuration files being JS specific to the assets/admin folder.

Why?

Because that frees up the root directory for whatever people want to do there.

It also has the drawback that the setup for the admin gets a lot more complicated (e.g. we have to set more paths, which is more error-prone and the CleanWebpackPlugin can't warn us anymore if we are deleting something outside of our project, because the folder we write the build to is already outside of its folder).

BC Breaks/Deprecations

The npm install and npm run build for building the admin has now to be executed in the assets/admin folder instead of the root folder.

To Do

  • Create a documentation PR
  • Create PR for sulu/sulu test skeleton
Copy link
Member

alexander-schranz left a comment

.travis.yml need to be changed to test the npm run build in the correct folder


module.exports = (env, argv) => {
env = env ? env : {};
argv = argv ? argv : {};

env.root_path = __dirname;
env.project_root_path = path.resolve(__dirname, '..', '..');
env.node_modules_path = path.resolve(__dirname ,'node_modules');

This comment has been minimized.

Copy link
@alexander-schranz

alexander-schranz Aug 28, 2019

Member

space at the false place:

-    env.node_modules_path = path.resolve(__dirname ,'node_modules');
+    env.node_modules_path = path.resolve(__dirname, 'node_modules');
@danrot danrot force-pushed the danrot:feature/move-package-json branch from 81473f6 to 691f1cb Aug 28, 2019
@danrot danrot force-pushed the danrot:feature/move-package-json branch from 691f1cb to f4c4cdb Aug 28, 2019
@danrot danrot referenced this pull request Aug 28, 2019
1 of 4 tasks complete
danrot added 2 commits Aug 28, 2019
@danrot danrot force-pushed the danrot:feature/move-package-json branch from 6b22438 to e340849 Aug 28, 2019
@alexander-schranz alexander-schranz merged commit 55daa19 into sulu:develop Aug 28, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danrot danrot deleted the danrot:feature/move-package-json branch Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.