New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed preview style-link #3930

Merged
merged 1 commit into from Apr 26, 2018

Conversation

Projects
None yet
2 participants
@wachterjohannes
Member

wachterjohannes commented Apr 25, 2018

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets none
Related issues/PRs none
License MIT
Documentation PR none

What's in this PR?

This PR fixes a problem which was introduced by #3899. It replaces the href of style tags and destroys website styling in preview.

@danrot

This comment has been minimized.

Member

danrot commented Apr 25, 2018

@wachterjohannes I think that shouldn't go into develop but to master instead, right?

@wachterjohannes wachterjohannes changed the base branch from develop to master Apr 25, 2018

@danrot

danrot approved these changes Apr 25, 2018

You can merge it if the build succeeds.

@danrot danrot merged commit a508a47 into sulu:master Apr 26, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wachterjohannes wachterjohannes deleted the wachterjohannes:hotfix/preview-style branch Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment