Add RouteBuilders #4276
Merged
Add RouteBuilders #4276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrot
force-pushed
the
feature/route-builder
branch
6 times, most recently
from
79057e0
to
0954883
Compare
danrot
commented
Nov 22, 2018
src/Sulu/Bundle/AdminBundle/Admin/Routing/DatagridRouteBuilder.php
Outdated
Show resolved
Hide resolved
danrot
force-pushed
the
feature/route-builder
branch
from
fe688eb
to
edf5bb2
Compare
chirimoya
requested changes
Nov 26, 2018
| ); | ||
| } | ||
|
|
||
| return $this->route; |
danrot
force-pushed
the
feature/route-builder
branch
2 times, most recently
from
7c0a4fa
to
d8d3fb9
Compare
danrot
force-pushed
the
feature/route-builder
branch
from
d8d3fb9
to
6019ec8
Compare
danrot
force-pushed
the
feature/route-builder
branch
from
6019ec8
to
a91bd89
Compare
chirimoya
requested changes
Dec 21, 2018
| public function setResourceKey(string $resourceKey): self; | ||
|
|
||
| /** | ||
| * @param array $locales |
UPGRADE.md
Outdated
| to use the `RouteBuilderFactory`. It offers methods to create Form, Datagrid and ResourceTabs routes in a typed way, | ||
| which means auto completion in the IDE should work as well. | ||
|
|
||
| Apart from that the `Route::addOption` was renamed to `Route::setOption`, since it overrides existing option values. |
There was a problem hiding this comment.
add addAttributeDefault change
| ->getRoute(), | ||
| $this->routeBuilderFactory->createFormRouteBuilder('sulu_category.add_form.detail', '/details') | ||
| ->setResourceKey('categories') | ||
| ->setFormKey('categories') |
danrot
force-pushed
the
feature/route-builder
branch
2 times, most recently
from
62bef68
to
eaf68ef
Compare
danrot
force-pushed
the
feature/route-builder
branch
from
eaf68ef
to
241581b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds the
Builderpattern to create routes.Why?
Because it is more comfortable to work with.
To Do
ResourceTabsto first tab, if nothing is selected