Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable content manager to decide on crop for image formats #4464

Merged
merged 17 commits into from Mar 14, 2019

Conversation

danrot
Copy link
Contributor

@danrot danrot commented Mar 1, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets ---
Related issues/PRs requires #4457
License MIT
Documentation PR ---

What's in this PR?

This PR allows to choose the exact cropping for each format of a picture.

Why?

Because it was already possible in the 1.x series.

To Do

  • Create a documentation PR
  • Add breaking changes to UPGRADE.md
  • Actually save the crop
  • Test if the crop is correctly applied to the image

@danrot danrot added the Feature New functionality not yet included in Sulu label Mar 1, 2019
@danrot danrot modified the milestones: Release 2.1, Release 2.0 Mar 1, 2019
@danrot danrot marked this pull request as ready for review March 4, 2019 17:49
@danrot danrot force-pushed the feature/cropping branch 2 times, most recently from 625b930 to 01e89d9 Compare March 4, 2019 17:57
@chirimoya
Copy link
Member

chirimoya commented Mar 14, 2019

  • The cropped indicator is also displayed when no manuel crop is set

@chirimoya chirimoya merged commit f5b54c6 into sulu:develop Mar 14, 2019
@danrot danrot deleted the feature/cropping branch March 15, 2019 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included in Sulu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants