Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to extend existing CKEditor #4657

Merged
merged 5 commits into from Jul 31, 2019

Conversation

@danrot
Copy link
Member

danrot commented Jul 30, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets ---
Related issues/PRs ---
License MIT
Documentation PR ---

What's in this PR?

This PR allows to extend the existing CKEditor without creating a completely new one.

Why?

Because creating a complete new build just to add one more feature would be an overkill.

To Do

  • Create a documentation PR
  • Add breaking changes to UPGRADE.md
  • Fix CSS minification
danrot added 4 commits Jul 30, 2019
@danrot danrot force-pushed the danrot:feature/ckeditor-plugins branch from 89d3f75 to cface9d Jul 31, 2019
@chirimoya chirimoya merged commit a79f97a into sulu:develop Jul 31, 2019
4 checks passed
4 checks passed
PrettyCI Code formatting
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danrot danrot deleted the danrot:feature/ckeditor-plugins branch Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.