Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to ToolbarActions #4674

Merged
merged 8 commits into from Aug 12, 2019

Conversation

@danrot
Copy link
Member

danrot commented Aug 9, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets ---
Related issues/PRs ---
License MIT
Documentation PR ---

What's in this PR?

This PR adds options to the ToolbarActions.

Why?

This way it is easier to reuse logic, because no new JS components have to be implemented. Instead some existing ones can be configured.

To Do

  • Create a documentation PR
  • Add options to ListToolbarActions
  • "Fix" options in RouteBuilder to avoid mixed string and number keys in array
@danrot danrot force-pushed the danrot:feature/toolbar-action-options branch from d287316 to 315e35a Aug 12, 2019
@danrot danrot force-pushed the danrot:feature/toolbar-action-options branch from 315e35a to 2147b4e Aug 12, 2019
@danrot danrot force-pushed the danrot:feature/toolbar-action-options branch from 086192f to 9ff4842 Aug 12, 2019
@danrot danrot force-pushed the danrot:feature/toolbar-action-options branch from 9ff4842 to 0aaa6ef Aug 12, 2019
Copy link
Member

chirimoya left a comment

Permission check is missing for Save as draft & Copy locale

@chirimoya chirimoya merged commit 91d6986 into sulu:develop Aug 12, 2019
4 checks passed
4 checks passed
PrettyCI Code formatting
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danrot danrot deleted the danrot:feature/toolbar-action-options branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.