Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package.json to assets folder #4708

Merged
merged 8 commits into from Aug 28, 2019

Conversation

@danrot
Copy link
Member

danrot commented Aug 28, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets ---
Related issues/PRs sulu/sulu-minimal#196
License MIT
Documentation PR ---

What's in this PR?

This PR makes more configurations possible regarding the build.

Why?

Because we want to move the package.json file in sulu-minimal away from the root directory, see sulu/sulu-minimal#196

BC Breaks/Deprecations

None yet

To Do

  • Create a documentation PR
  • Add breaking changes to UPGRADE.md
  • Move index.js file to root?
  • Update the other packages
@danrot danrot changed the title Feature/move package json Move package.json to assets folder Aug 28, 2019
@danrot danrot force-pushed the danrot:feature/move-package-json branch 3 times, most recently from 9e1db1d to a52aded Aug 28, 2019
@danrot danrot force-pushed the danrot:feature/move-package-json branch from a52aded to f6108e4 Aug 28, 2019
@alexander-schranz alexander-schranz merged commit 85804e2 into sulu:develop Aug 28, 2019
4 checks passed
4 checks passed
PrettyCI Code formatting
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danrot danrot deleted the danrot:feature/move-package-json branch Aug 28, 2019
@danrot danrot referenced this pull request Aug 28, 2019
0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.