Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PortalLoader to generate download route for media correctly #5053

Merged

Conversation

danrot
Copy link
Contributor

@danrot danrot commented Feb 11, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets ---
Related issues/PRs #5024
License MIT
Documentation PR ---

What's in this PR?

This PR changes the way routes for portals created the portal type are created. This is only an internal change, and does not affect how these routes are configured.

Why?

Because the route for e.g. the website search was created without a leading slash, which caused problems in the Symfony router. It somehow generated the routes, so that the search path was appended to the download route for media, which caused the original download route to not be available anymore.

@danrot danrot marked this pull request as ready for review February 11, 2020 13:22
@alexander-schranz alexander-schranz merged commit 1a11cbe into sulu:release/2.0 Feb 11, 2020
@danrot danrot deleted the bugfix/media-download-route branch February 11, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants