Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove z-index values #5138

Merged
merged 6 commits into from Mar 26, 2020
Merged

Conversation

danrot
Copy link
Contributor

@danrot danrot commented Mar 25, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets ---
Related issues/PRs #5035
License MIT
Documentation PR ---

What's in this PR?

This PR removes all z-index values, and sometimes has to reorder some HTML components to make this possible.

Why?

This PR fixes a problem that occured in #5035. The dropdown filter introduced there could only be closed if something outside of the FieldFilterItem (containing the ArrowMenu) was clicked. Now it is possible to also click on the ArrowMenu to close it.

To Do

  • Test in different browser

@@ -8,7 +8,6 @@ $dropAreaInfoColor: $white;
position: fixed;
top: 0;
left: 0;
z-index: 1;
Copy link
Contributor Author

@danrot danrot Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to work anymore after changing the Header

@danrot
Copy link
Contributor Author

danrot commented Mar 25, 2020

@nnatter Tested this already in chrome, firefox and safari, and didn't encounter any errors 🙂 The important thing to test is the dropdown error you have found in #5035, this should work now as well.

@niklasnatter
Copy link
Member

niklasnatter commented Mar 26, 2020

Did encounter two quirks while testing this, otherwise it is looking good:

@danrot
Copy link
Contributor Author

danrot commented Mar 26, 2020

@nnatter Both issues should be fixed now. And "is using z-index" becomes a new criteria when choosing a 3rd party package 🙈

@niklasnatter
Copy link
Member

niklasnatter commented Mar 26, 2020

works like a charm 🙂

@niklasnatter niklasnatter merged commit e168da4 into sulu:master Mar 26, 2020
4 of 5 checks passed
@danrot danrot deleted the feature/remove-z-index branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants