-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove z-index values #5138
Remove z-index values #5138
Conversation
@@ -8,7 +8,6 @@ $dropAreaInfoColor: $white; | |||
position: fixed; | |||
top: 0; | |||
left: 0; | |||
z-index: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem to work anymore after changing the Header
@nnatter Tested this already in chrome, firefox and safari, and didn't encounter any errors 🙂 The important thing to test is the dropdown error you have found in #5035, this should work now as well. |
Did encounter two quirks while testing this, otherwise it is looking good:
|
@nnatter Both issues should be fixed now. And "is using z-index" becomes a new criteria when choosing a 3rd party package 🙈 |
works like a charm 🙂 |
What's in this PR?
This PR removes all
z-index
values, and sometimes has to reorder some HTML components to make this possible.Why?
This PR fixes a problem that occured in #5035. The dropdown filter introduced there could only be closed if something outside of the
FieldFilterItem
(containing theArrowMenu
) was clicked. Now it is possible to also click on theArrowMenu
to close it.To Do