Fix MediaDataProvider if no security is configured #5580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrot
force-pushed
the
bugfix/media-smart-content-without-security
branch
from
d26a7b4
to
f5a4b3f
Compare
alexander-schranz
requested changes
Oct 30, 2020
There was a problem hiding this comment.
Optional parameters should be at the end, else it will fail in the next version of php. So maybe we just make it nullable using ?Security $security,
| @@ -45,7 +45,7 @@ public function __construct( | |||
| ArraySerializerInterface $serializer, | |||
| RequestStack $requestStack, | |||
| ReferenceStoreInterface $referenceStore, | |||
| Security $security, | |||
| Security $security = null, | |||
There was a problem hiding this comment.
optional parameters in the middle is not longer allowed: https://php.watch/versions/8.0/deprecate-required-param-after-optional
So we would need to add it to the end or use ?Security $security
There was a problem hiding this comment.
Woah, that's a heavy change. Gonna fix it.
alexander-schranz
approved these changes
Oct 30, 2020
danrot
force-pushed
the
bugfix/media-smart-content-without-security
branch
from
ba70d3e
to
684a676
Compare
alexander-schranz
added
the
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR fixes the signature of the
MediaDataProviderconstructor to also acceptnullfor theSecurityclass.Why?
Because if no security is configured in
config/packages/security_website.yamltheSecurityclass is not available and therefore null. In that case the website currently breaks, if a SmartContent displaying media is on the page.