New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

titlebar hard to grab when many tabs open #1053

Open
e4711s opened this Issue Aug 3, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@e4711s
Copy link

e4711s commented Aug 3, 2018

In tab mode the tabs reach into the titlebar, leaving only a couple of free pixels above the tabs to grab the window.

@GitHubRulesOK

This comment has been minimized.

Copy link

GitHubRulesOK commented Aug 4, 2018

That is unusual
you possibly know that you can from the pull down menu use Window > Move then any arrow key will allow you to move the window.
As to cause, it may be related to screen dpi can you confirm resolution of screen AND what percent your working to, usually found by right click on desktop then select display settings ?
Also if using Win 10 have you triggered Advanced scaling e.g. is "Fix scaling for apps" on or have you changed custom scaling (not recommended)

@SumatraPeter

This comment has been minimized.

Copy link

SumatraPeter commented Aug 6, 2018

That is unusual

@GitHubRulesOK: Here's the 'grabbable' area of Sumatra's titlebar, which admittedly is a bit narrow:

image

Perhaps the tabs could be redesigned to take up the entire height of the titlebar as in the case of Firefox, but leave clear gaps on both sides to aid in grabbing and moving the window with a mouse.

image

Note a clever aspect of Firefox's design, in that the empty area to the left of the tabs disappears when the window is maximized (the first tab starts right at the top left of the window in that case).

Various tab-related improvements have been on my wish list ever since Sumatra started supporting tabs (see here and linked GitHub issues), but unfortunately there's no-one around to implement any of them. 😞

@GitHubRulesOK

This comment has been minimized.

Copy link

GitHubRulesOK commented Aug 6, 2018

Peter whilst I agree there are many requests/improvements needed for tabs
I see the area above yours is about 14 pixels (the same as mine when not full screen), rather than the "couple" (two?) as mentioned by @e4711s hence the That is unusual
I have on occasion mishandled a tag and moved it rather than the whole window but I put that down to my haste or bad eye co-ordination.
Personally I think the current tabs look ok when maximised and (apart from color/logo) not that different to your Firefox example (which seems to have a space top left) and I would rather find the tribar options button in the traditional top left menu position well away from close / resize etc at top right see my screen
untitled

It is difficult to meet everyone's preference for layout since the ribbon brigade want more and more buttons and the tabs brigade want to tear them away etc I just don't know how many ways the original concept could be changed as it started out to provide a fast reading area to the max (same as MuPDF) but with more access to the basic underlying functions.
I did point out to @kjk there was a separate fork with "close all tabs" but as he currently seems otherwise stretched work/health/family/many other projects ? it may be a while before its PR'd and probably not a big enough change to placate the tabbies (though IMHO it could be added to Pre-release)

@SumatraPeter

This comment has been minimized.

Copy link

SumatraPeter commented Aug 8, 2018

rather than the "couple" (two?) as mentioned by @e4711s

I took the word "couple" to generally imply a small number and not literally to be read as "two". Even if it is 14px (I didn't count), I do find it to be rather narrow to be able to grab hold of quickly/easily. Let's also not forget that when the cursor gets too close to the top edge it changes into "resize window mode" and no longer simply grabs the titlebar as intended.

Personally I think the current tabs look ok when maximised and (apart from color/logo) not that different to your Firefox example (which seems to have a space top left)

Yes, my FF screenshot displays the blank grabbable area at the top left since clearly the window is not maximized.

My suggestion would be three-fold. As you've pointed out in your Sumatra screenshot, the grabbable area to the right between the last tab and the minimize button is variable in width. So first of all I'd make it fixed-width like FF does, to provide a consistent area to be targeted with the mouse for grabbing.

Second, since introducing another grabbable area to the top left of the non-maximized window (like FF does) would interfere with the hamburger menu, I'd see if the square menu button itself can also be used to drag if the mouse is left-clicked and held on it. I'm pretty sure that can be managed. So left-click it once and the menu would open as usual, but left-click and drag and the menu would close and window would get dragged.

Finally, since these changes will effectively replicate FF's two grabbable areas on both sides of the tabs, when the window is non-maximized I'd make Sumatra's tabs full height to cover the titlebar, again just like FF (since that narrow horizontal strip on top is a poor target anyway and would no longer be required).

Anyway, all these are ideas that will most likely remain just that, because as Krzysztof has previously pointed out Sumatra is in an inactive state development-wise right now, and even otherwise the responsibility of all the piled up bug fixes, feature requests, engine/library updates etc. is clearly way too much for one person with a day job to handle.

@SumatraPeter

This comment has been minimized.

Copy link

SumatraPeter commented Jan 23, 2019

Forum issue with more details about the bug that causes the tabs to even overlay the min/max/close buttons sometimes: https://forum.sumatrapdfreader.org/t/feature-request-drag-space-next-to-the-minimize-maximize-title-bar-buttons/1911/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment