New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobi and djvu thumbnails are not showing up #1078

Open
faridcher opened this Issue Sep 22, 2018 · 10 comments

Comments

Projects
None yet
5 participants
@faridcher
Copy link

faridcher commented Sep 22, 2018

While pdf and epub thumbnails show fine, mobi and djvu don't.

@GitHubRulesOK

This comment has been minimized.

Copy link

GitHubRulesOK commented Sep 22, 2018

Thumbnails is a generic term, within SumatraPDF they are shown on the Frequently Read page and are ALL stored as one type (.png) so they are either ALL visible or not irrespective of document type.
untitled
If you are referring to previewer images in your operating system you need to confirm more details about the version bitness etc.

@faridcher

This comment has been minimized.

Copy link

faridcher commented Sep 22, 2018

I mean in the shell (Windows File Explorer). I use the latest sumatraPDF and I am on Win 10.

@GitHubRulesOK

This comment has been minimized.

Copy link

GitHubRulesOK commented Sep 22, 2018

win10 no sumatra

Win 10 WITHOUT SumatraPDF

win10 with sumatra

Win 10 WITH SumatraPDF

Sumatra only adds a previewer for PDF (and changes icons for most of the files it is registered with)
It is generally windows that controls the thumbnails outside SumatraPDF

@faridcher

This comment has been minimized.

Copy link

faridcher commented Sep 22, 2018

Microsoft has provided some interfaces for this purpose; they are called shell extension handlers (https://docs.microsoft.com/windows/desktop/shell/handlers). I could figure out how to enable thumnail for epub, i.e., by adding an image to the root of the epub file structure (https://www.zabkat.com/blog/epub-thumbnails-author.htm). Unlike epub, Mobi and djvu are binary formats and (I think) it is easy for an application that handles certain file types, to implement these interfaces. For PDFs we get the first page of the file as thumbnail.

thanks

@GitHubRulesOK

This comment has been minimized.

Copy link

GitHubRulesOK commented Sep 22, 2018

Ok now I understand it is changes to the file handling code. You wish to achieve "Live Icons"
I have in the past seen mods to preview some of the formats supported by SumatraPDF for more information see https://forum.sumatrapdfreader.org/t/preview-handlers-build-error/55 and also enhanced versions of the dlls used by other explorers (e.g. XY) that have thumbnail features
So it is not strictly an "Issue" with the program as designed (it works the way it "should") providing static icons when registered.
I am not the developer however I suggest you need to be more specific about what you want.
IF you are offering to extend the code to add additional "Live" thumbnail handling features and having problems then its best to raise a detailed explanation of where your compilation is failing

Note it is NOT SumatraPDF showing the thumbnail in windows as shown in first screenshot above
that is done by code within Win10.

Normally a pdf does not have an embedded preview, hence the need for SumatraPDF reader to render the whole scrollable document in the preview window (it is not just the first page which you might see)
[Later edit] This scrolling feature applies to all previewed files with multiple pages similar to a mini viewer

NONE of the Win10 shell thumbnails are generated by SumatraPDF, that's not its current function.

@kjk I think this can be closed as "works as currently designed"

@SumatraPeter

This comment has been minimized.

Copy link

SumatraPeter commented Sep 22, 2018

Duplicate of #382.

PDF

Only PDF previews are currently supported. From what I understand, thumbnail handlers for other formats are part of the code but deliberately disabled since the dev has been waiting for years for someone to submit icons for those file types (and no free icon set has been found suitable). Personally I feel a mere lack of icons shouldn't block users from benefiting from such a useful feature, but maybe there are other reasons for the decision...

@GitHubRulesOK

This comment has been minimized.

Copy link

GitHubRulesOK commented Sep 23, 2018

Thanks Peter I had lost site of those builds only related change since they were last updated is TIF support but windows does that anyway.
untitledi

@musm

This comment has been minimized.

@GitHubRulesOK

This comment has been minimized.

Copy link

GitHubRulesOK commented Oct 3, 2018

For discussion on icons Please use #600
To answer you suggestion here this is what they look like at 16 pelsx4if_pdf_icon_1067101719391-mobi
for comparison here is current SumatraPDF needing Admin rights sumatra admin
This thread is not about icons it is about live thumbnails / preview

@ianamk

This comment has been minimized.

Copy link

ianamk commented Oct 7, 2018

afaik the extra preview handlers are disabled by default until new icons for those formats can be found
if you want them you'd need to compile sumatrapdf on your own see this thread on the sumatra forums
https://forum.sumatrapdfreader.org/t/preview-handlers-build-error/55
basically you need to edit premake5.lua and premake5.files.lua to enable the extra handlers then use premake5 to generate new visual studio project files zeniko use to provide builds that had the preview handlers enabled but he's been missing for a few years now I hope he's allright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment